Csaba Ringhofer has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/24515


Change subject: IMPALA-15118: Copy ByteBuffers for partitionList_
......................................................................

IMPALA-15118: Copy ByteBuffers for partitionList_

IcebergContentFileStore.fromThrift() didn't copy the contents
of ByteBuffers when filling partitionList_.
Thrift's binary handling in Java is special as the ByteBuffer
object in deserialized Thrift object can still reference the
transport buffer. Keeping the reference to that can almost
double the size of IcebergContentFileStore in the coordinator.

Another issue fixed is that partitionMap_ and partitionList_ did
not share the ByteBuffers  after fromThrift()

Improvement for test table with 1M files, 25K partitions:
665MB->389MB

Change-Id: Ib39940dd64aadcb094b099e3863dd42c22afc2b8
---
M fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java
1 file changed, 7 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/24515/1
--
To view, visit http://gerrit.cloudera.org:8080/24515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib39940dd64aadcb094b099e3863dd42c22afc2b8
Gerrit-Change-Number: 24515
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <[email protected]>

Reply via email to