Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10846 )
Change subject: IMPALA-7224. Improve performance of UpdateCatalogMetrics ...................................................................... IMPALA-7224. Improve performance of UpdateCatalogMetrics This function is called after every DDL query, and was implemented by fetching the entire list of table names, even though only the length of that list was needed. In workloads with millions of tables, this could add several seconds of overhead following even simple requests like 'USE' or 'DESCRIBE'. I tested a backported version of this patch against one such workload. It reduced the time taken for a simple DESCRIBE query from 12-14sec down to about 40ms. I also tested locally that the metrics on impalad were still updated by DDL operations. Change-Id: Ic5467adbce1e760ff93996925db5611748efafc0 Reviewed-on: http://gerrit.cloudera.org:8080/10846 Reviewed-by: Vuk Ercegovac <[email protected]> Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/service/frontend.cc M be/src/service/frontend.h M be/src/service/impala-server.cc M common/thrift/Frontend.thrift M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/main/java/org/apache/impala/service/JniFrontend.java 6 files changed, 40 insertions(+), 11 deletions(-) Approvals: Vuk Ercegovac: Looks good to me, approved Tim Armstrong: Looks good to me, but someone else must approve Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic5467adbce1e760ff93996925db5611748efafc0 Gerrit-Change-Number: 10846 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
