Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/24137 )
Change subject: IMPALA-13810: Generate lineage records for UPDATE and MERGE statements ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/24137/11/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/24137/11/fe/src/main/java/org/apache/impala/planner/Planner.java@261 PS11, Line 261: addTargetColumnLabelsForLineage > Please break up this method for readability. Done http://gerrit.cloudera.org:8080/#/c/24137/11/testdata/workloads/functional-query/queries/QueryTest/lineage-iceberg-update-merge.test File testdata/workloads/functional-query/queries/QueryTest/lineage-iceberg-update-merge.test: http://gerrit.cloudera.org:8080/#/c/24137/11/testdata/workloads/functional-query/queries/QueryTest/lineage-iceberg-update-merge.test@353 PS11, Line 353: { : "sources": [ : 0 : ], : "targets": [ : 0 : ], : "edgeType": "PROJECTION" : } > Why do we have this block? We're updating event_time based on its own value, so that's why the projection to itself. http://gerrit.cloudera.org:8080/#/c/24137/11/testdata/workloads/functional-query/queries/QueryTest/lineage-iceberg-update-merge.test@810 PS11, Line 810: { : "sources": [ : 0 : ], : "targets": [ : 0 : ], : "edgeType": "PROJECTION" : } > Why do we have this block? I think in the update case, it reinserts the modified rows and only changes the user column, so the others are just copies. -- To view, visit http://gerrit.cloudera.org:8080/24137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icba79f756509438455bfbf3067733f6f29284220 Gerrit-Change-Number: 24137 Gerrit-PatchSet: 12 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 26 Jun 2026 15:15:52 +0000 Gerrit-HasComments: Yes
