Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24521 )
Change subject: IMPALA-15052: Add read support for unshredded VARIANT values ...................................................................... Patch Set 1: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24521/1/be/src/runtime/raw-value.cc File be/src/runtime/raw-value.cc: http://gerrit.cloudera.org:8080/#/c/24521/1/be/src/runtime/raw-value.cc@309 PS1, Line 309: // Unlike a struct, a variant value is not a StructVal: 'value' points at the raw 24-byte line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24521/1/fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java File fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java: http://gerrit.cloudera.org:8080/#/c/24521/1/fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java@361 PS1, Line 361: // UNION/INTERSECT/EXCEPT (DISTINCT) must hash/compare the result columns, which is line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24521/1/fe/src/main/java/org/apache/impala/analysis/SetOperationStmt.java@690 PS1, Line 690: // null for it (see SlotRef.reExpandVariant for the same reasoning in sort tuples). line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24521/1/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java File fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java: http://gerrit.cloudera.org:8080/#/c/24521/1/fe/src/main/java/org/apache/impala/analysis/SlotDescriptor.java@430 PS1, Line 430: if (type_.isScalarType() || type_.isStructType() || type_.isVariantType()) return materializedPath; line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/24521/1/fe/src/main/java/org/apache/impala/catalog/Type.java File fe/src/main/java/org/apache/impala/catalog/Type.java: http://gerrit.cloudera.org:8080/#/c/24521/1/fe/src/main/java/org/apache/impala/catalog/Type.java@36 PS1, Line 36: import org.apache.impala.thrift.TTypeNodeType; unused import: org.apache.impala.thrift.TTypeNodeType http://gerrit.cloudera.org:8080/#/c/24521/1/fe/src/main/java/org/apache/impala/catalog/Type.java@173 PS1, Line 173: * representation. Impala still reads the real VARIANT type from the Iceberg metadata, so line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24521/1/tests/util/iceberg_metadata_util.py File tests/util/iceberg_metadata_util.py: http://gerrit.cloudera.org:8080/#/c/24521/1/tests/util/iceberg_metadata_util.py@126 PS1, Line 126: ) flake8: E501 line too long (92 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/24521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f8a7c9b1d4e5f6a0c3b8d7e9f1a2b4c6d8e0f1 Gerrit-Change-Number: 24521 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 29 Jun 2026 13:02:26 +0000 Gerrit-HasComments: Yes
