Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/24529 )
Change subject: IMPALA-15129: Fix test_no_tuniqueid false positives from
coverage/results dirs
......................................................................
IMPALA-15129: Fix test_no_tuniqueid false positives from coverage/results dirs
assert_message_absent walks all files under $IMPALA_LOGS_DIR, which
inadvertently matches TUniqueId in non-daemon-log files:
- pytest JUnit XML (logs/ee_tests/results/): failure tracebacks capture
TUniqueId.__repr__() from Python test local variables
- Jacoco HTML coverage (logs/fe_tests/coverage/): rendered Java source
contains Thrift-generated constructor calls like new TUniqueId(...)
- gcovr HTML coverage (logs/coverage/): rendered C++ source contains
e.g. NAME##_catalogd_registration_id_ = TUniqueId()
Add a skip_subdirs parameter to assert_message_absent that prunes the
os.walk traversal in-place. test_no_tuniqueid passes
skip_subdirs={'coverage', 'results'} to exclude all three categories.
Change-Id: I275e34724ab16db9225389b1299c5c4f10bc878a
Assisted-by: Claude Sonnet 4.6 (GitHub Copilot)
Reviewed-on: http://gerrit.cloudera.org:8080/24529
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M tests/verifiers/test_banned_log_messages.py
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24529
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I275e34724ab16db9225389b1299c5c4f10bc878a
Gerrit-Change-Number: 24529
Gerrit-PatchSet: 3
Gerrit-Owner: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
