Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: WIP: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@893 PS1, Line 893: * EXPAND_COMPLEX_TYPES is set to false (it defaults to true); see addStarExpandedPath(). line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1119 PS1, Line 1119: AnalyzesOk("select complex_struct_col.* from functional.allcomplextypes", ctxNoExpand); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/24543/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@582 PS1, Line 582: // This file's golden lineage predates EXPAND_COMPLEX_TYPES defaulting to true; keep '*' line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2 Gerrit-Change-Number: 24543 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 03 Jul 2026 14:12:39 +0000 Gerrit-HasComments: Yes
