Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24297 )
Change subject: IMPALA-14600: Support HBO for AggregationNode cardinality ...................................................................... Patch Set 9: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24297/9/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java File fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java: http://gerrit.cloudera.org:8080/#/c/24297/9/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@257 PS9, Line 257: * Regression test for the FOR_HBO rendering of a grouping SlotRef on a column whose name line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24297/9/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@259 PS9, Line 259: * output tuple (see AggregationNode.init() after computeStats()), the ref is rebuilt via line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24297/9/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@261 PS9, Line 261: * be recovered from the descriptor's source expr (retained by SlotDescriptor.initFromExpr) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24297/9/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@275 PS9, Line 275: // The grouping expr's source column is literally named `name`one` (internal backtick). line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24297/9/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@282 PS9, Line 282: // Building the ref from the (non-scan) descriptor drops rawPath_, matching substitution. line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24297/9/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@285 PS9, Line 285: // The unsubstituted source column (rawPath_ set) renders identically, without parsing. line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0fafaf9d827f3bf533b1af7e62fdb2303c126ce Gerrit-Change-Number: 24297 Gerrit-PatchSet: 9 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 06 Jul 2026 06:31:30 +0000 Gerrit-HasComments: Yes
