Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24556 )

Change subject: [WIP] IMPALA-15127: Support HBO for UnionNode cardinality
......................................................................


Patch Set 1:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24556/1/fe/src/main/java/org/apache/impala/planner/UnionNode.java
File fe/src/main/java/org/apache/impala/planner/UnionNode.java:

http://gerrit.cloudera.org:8080/#/c/24556/1/fe/src/main/java/org/apache/impala/planner/UnionNode.java@21
PS1, Line 21: import java.util.Collections;
unused import: java.util.Collections


http://gerrit.cloudera.org:8080/#/c/24556/1/fe/src/main/java/org/apache/impala/planner/UnionNode.java@370
PS1, Line 370:     List<PlanNode.HboKeyedNode> sortedChildren = 
PlanNode.buildSortedHboNodes(statsType, strategy, children_);
line too long (110 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie228f530bdcb171d3b717966673164bf9a4c45c8
Gerrit-Change-Number: 24556
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Mon, 06 Jul 2026 14:10:03 +0000
Gerrit-HasComments: Yes

Reply via email to