Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24557 )
Change subject: WIP: IMPALA-15057: Add variant_get() builtin and first-class VARIANT expressions ...................................................................... Patch Set 1: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24557/1/be/src/exprs/anyval-util.h File be/src/exprs/anyval-util.h: http://gerrit.cloudera.org:8080/#/c/24557/1/be/src/exprs/anyval-util.h@347 PS1, Line 347: // slot -> VariantVal conversion already happened in SlotRef::GetVariantValInterpreted. line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/24557/1/be/src/exprs/scalar-expr-evaluator.cc File be/src/exprs/scalar-expr-evaluator.cc: http://gerrit.cloudera.org:8080/#/c/24557/1/be/src/exprs/scalar-expr-evaluator.cc@387 PS1, Line 387: // and value). Store it in result_ and return a pointer to it, mirroring TYPE_STRUCT. line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24557/1/be/src/exprs/variant-functions-ir.cc File be/src/exprs/variant-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/24557/1/be/src/exprs/variant-functions-ir.cc@287 PS1, Line 287: // DATE stores days-since-epoch; INT32 is accepted as a day count (see coercion table). line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24557/1/be/src/util/variant-util.cc File be/src/util/variant-util.cc: http://gerrit.cloudera.org:8080/#/c/24557/1/be/src/util/variant-util.cc@57 PS1, Line 57: return VariantToJson(v.metadata.ptr, v.metadata.len, v.value.ptr, v.value.len, json_out); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24557/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/24557/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java@763 PS1, Line 763: throw new AnalysisException(fnName_.getFunction() + "() unsupported target type '" line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24557/1/fe/src/main/java/org/apache/impala/catalog/Type.java File fe/src/main/java/org/apache/impala/catalog/Type.java: http://gerrit.cloudera.org:8080/#/c/24557/1/fe/src/main/java/org/apache/impala/catalog/Type.java@36 PS1, Line 36: import org.apache.impala.thrift.TTypeNodeType; unused import: org.apache.impala.thrift.TTypeNodeType -- To view, visit http://gerrit.cloudera.org:8080/24557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55bfed394ac2fb57135fadedd489f59e4cc10de4 Gerrit-Change-Number: 24557 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 06 Jul 2026 19:48:56 +0000 Gerrit-HasComments: Yes
