Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22094 )
Change subject: IMPALA-13533: Calcite CTE backend ...................................................................... Patch Set 45: (2 comments) Recent Calcite exchange work changed some of the CTE plans (probably for the better) and exposed some false assumptions in scheduling. I believe I've fixed them, and TPC-DS with MT_DOP=0 and MT_DOP=5 both work again. http://gerrit.cloudera.org:8080/#/c/22094/44/be/src/exec/cte-consumer-node.cc File be/src/exec/cte-consumer-node.cc: http://gerrit.cloudera.org:8080/#/c/22094/44/be/src/exec/cte-consumer-node.cc@44 PS44, Line 44: DCHECK_EQ(cte_node.input_row_tuples.size(), cte_node.nullable_tuples.size()); > Size of input_row_tuples and nullable_tuples don't have to match. I'm not s Done http://gerrit.cloudera.org:8080/#/c/22094/44/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/22094/44/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@180 PS44, Line 180: result = childFragments.get(0); > This probably needs to update tupleIds_ in case the child under the CTEProd Done -- To view, visit http://gerrit.cloudera.org:8080/22094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48f16d495d4b37be97e6a913f0eb5b94d70e199a Gerrit-Change-Number: 22094 Gerrit-PatchSet: 45 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 06 Jul 2026 22:39:38 +0000 Gerrit-HasComments: Yes
