Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23805 )
Change subject: IMPALA-14637: COMMIT_TXN events should trigger reload for truncate ops ...................................................................... Patch Set 14: (6 comments) http://gerrit.cloudera.org:8080/#/c/23805/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23805/12//COMMIT_MSG@29 PS12, Line 29: gered based > nit: typo Done http://gerrit.cloudera.org:8080/#/c/23805/12/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/23805/12/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@987 PS12, Line 987: (tableNames_.isEmpty()) r > Should we remove the truncate ops in an else branch? Nice catch! AbortTxnEvent removes the truncate ops in the constructor. We should do the same for CommitTxnEvent. http://gerrit.cloudera.org:8080/#/c/23805/12/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1221 PS12, Line 1221: Notific > tracked? Done http://gerrit.cloudera.org:8080/#/c/23805/12/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1222 PS12, Line 1222: MIT_TXN. F > Will our tests fail when HIVE-29677 resolves? That's a good point. The test won't fail but we might reload some partitions twice. Changed the type of 'writeEvents' to a Set and implement hashCode() and equals() in TableWriteEvent. http://gerrit.cloudera.org:8080/#/c/23805/12/fe/src/main/java/org/apache/impala/catalog/Catalog.java File fe/src/main/java/org/apache/impala/catalog/Catalog.java: http://gerrit.cloudera.org:8080/#/c/23805/12/fe/src/main/java/org/apache/impala/catalog/Catalog.java@1015 PS12, Line 1015: Preconditions.checkN > Should we skip it if writeId_ <= 0? E.g. in case of Apache Hive 3? Done. Adding these would leak in the map. http://gerrit.cloudera.org:8080/#/c/23805/11/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/23805/11/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@4485 PS11, Line 4485: > I think the flaky test cover this: https://github.com/apache/impala/blob/d5 Done -- To view, visit http://gerrit.cloudera.org:8080/23805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89aac12819f08dd9ed42d5d8b21a96c04b04d75c Gerrit-Change-Number: 23805 Gerrit-PatchSet: 14 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 06:29:09 +0000 Gerrit-HasComments: Yes
