Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23835 )
Change subject: IMPALA-14516: [DOCS] Documentation for AES Encryption/Decryption Support in Impala ...................................................................... Patch Set 2: (4 comments) Thanks for writing the docs, Sanjana! I left some comments that clarify the differences between modes and highlights some important info. http://gerrit.cloudera.org:8080/#/c/23835/2/docs/topics/impala_aes_encryp_decryp.xml File docs/topics/impala_aes_encryp_decryp.xml: http://gerrit.cloudera.org:8080/#/c/23835/2/docs/topics/impala_aes_encryp_decryp.xml@44 PS2, Line 44: The implementation includes : key length and initialization vectors vector size validation to ensure data integrity and : confidentiality. nit: I would remove this sentence, it does not make sense to me. The validation is for correctness. Confidentiality is a result of the encryption in all modes, integrity is only checked in certain AES modes (in this case, GCM of the supported modes). http://gerrit.cloudera.org:8080/#/c/23835/2/docs/topics/impala_aes_encryp_decryp.xml@86 PS2, Line 86: with the same key I would add that this mode does not have IV (because on L47 you mention IV generally, reader could assume it is for all modes). http://gerrit.cloudera.org:8080/#/c/23835/2/docs/topics/impala_aes_encryp_decryp.xml@86 PS2, Line 86: It is included for compatibility with : legacy systems and is only supported for decryption You can add that it is because now ECB is considered insecure. http://gerrit.cloudera.org:8080/#/c/23835/2/docs/topics/impala_aes_encryp_decryp.xml@149 PS2, Line 149: '' Point out that ECB does not have IV, that's why this is an empty string parameter. -- To view, visit http://gerrit.cloudera.org:8080/23835 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34a30a3e98b5b44ea810470fc02e42059f60b5b8 Gerrit-Change-Number: 23835 Gerrit-PatchSet: 2 Gerrit-Owner: Sanjana Malhotra <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Sanjana Malhotra <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 13:42:24 +0000 Gerrit-HasComments: Yes
