Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24089 )
Change subject: IMPALA-14850: Codegen tuple DeepCopy for hash join ...................................................................... Patch Set 22: Code-Review+1 (4 comments) lgtm, only optional beautification ideas http://gerrit.cloudera.org:8080/#/c/24089/22/be/src/runtime/buffered-tuple-stream-test.cc File be/src/runtime/buffered-tuple-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/24089/22/be/src/runtime/buffered-tuple-stream-test.cc@406 PS22, Line 406: use_deepcopy_add_row maybe "use_codegen"? http://gerrit.cloudera.org:8080/#/c/24089/22/be/src/runtime/buffered-tuple-stream-test.cc@579 PS22, Line 579: CreateDescriptors This is not new code, but this seems to be also frequently used, just nullable_tuples seem to get different bools. http://gerrit.cloudera.org:8080/#/c/24089/22/be/src/runtime/buffered-tuple-stream-test.cc@605 PS22, Line 605: virtual void CreateCodegenFunctions() { : CodegenFnPtr<AddRowFn> int_add_row_codegen_fn; : CreateCodegenAddRowFn(int_desc_, int_add_row_codegen_fn); : CodegenFnPtr<AddRowFn> string_add_row_codegen_fn; : CreateCodegenAddRowFn(string_desc_, string_add_row_codegen_fn); : : ABORT_IF_ERROR(codegen_->FinalizeModule()); : : int_add_row_fn_ = int_add_row_codegen_fn.load(); : string_add_row_fn_ = string_add_row_codegen_fn.load(); This functions look the same - can't we unify them somehow? http://gerrit.cloudera.org:8080/#/c/24089/22/be/src/runtime/buffered-tuple-stream-test.cc@2067 PS22, Line 2067: int_desc_, int_add_row_fn_ Not sure if worth the effort, but TestValues could pick up descriptor and codegened_fn based on the template. Or an enum could specify which ones to use. -- To view, visit http://gerrit.cloudera.org:8080/24089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63e32babdbaf56095478c6c66afb9cb91189f946 Gerrit-Change-Number: 24089 Gerrit-PatchSet: 22 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 15:02:10 +0000 Gerrit-HasComments: Yes
