Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24559 )

Change subject: WIP AI: IMPALA-12700: Take Iceberg Parquet Bloom filter 
properties into account
......................................................................


Patch Set 1:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24559/1/fe/src/test/java/org/apache/impala/util/IcebergBloomFilterUtilTest.java
File fe/src/test/java/org/apache/impala/util/IcebergBloomFilterUtilTest.java:

http://gerrit.cloudera.org:8080/#/c/24559/1/fe/src/test/java/org/apache/impala/util/IcebergBloomFilterUtilTest.java@46
PS1, Line 46:   private static final String MAX_BYTES_PROP = 
IcebergTable.PARQUET_BLOOM_FILTER_MAX_BYTES;
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/24559/1/fe/src/test/java/org/apache/impala/util/IcebergBloomFilterUtilTest.java@70
PS1, Line 70:     
assertFalse(IcebergUtil.validateParquetBloomFilterProperties(props, new 
StringBuilder()));
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7baab79bbc055ddc8e2b05bbbc7083e02dc914e
Gerrit-Change-Number: 24559
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 07 Jul 2026 17:15:43 +0000
Gerrit-HasComments: Yes

Reply via email to