Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24544 )
Change subject: IMPALA-12422: Add Impala/Trino Iceberg V3 interop custom cluster test suite ...................................................................... Patch Set 3: (3 comments) Looks good in general, just a few comments. http://gerrit.cloudera.org:8080/#/c/24544/3/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/24544/3/tests/common/test_result_verifier.py@539 PS3, Line 539: if verifier and verifier.upper() == 'VERIFY_IS_EQUAL': : order_matters = True : if verifier and verifier.upper() == 'VERIFY_IS_EQUAL_SORTED': : order_matters = False Can you add tests that use these? http://gerrit.cloudera.org:8080/#/c/24544/3/tests/custom_cluster/test_trino_interop.py File tests/custom_cluster/test_trino_interop.py: http://gerrit.cloudera.org:8080/#/c/24544/3/tests/custom_cluster/test_trino_interop.py@88 PS3, Line 88: unique_database The database created here is not used - could use unique_name fixture. http://gerrit.cloudera.org:8080/#/c/24544/3/tests/custom_cluster/test_trino_interop.py@113 PS3, Line 113: # Impala only learns about out-of-band HMS objects after an INVALIDATE. : self.execute_query("INVALIDATE METADATA") HMS events still work, right? So Impala sees the database after bit of time. -- To view, visit http://gerrit.cloudera.org:8080/24544 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7706244f909f32dff4d390537e71877b0635c661 Gerrit-Change-Number: 24544 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Jul 2026 06:11:48 +0000 Gerrit-HasComments: Yes
