Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24417 )
Change subject: IMPALA-15081: Clarify timestamp filters ...................................................................... IMPALA-15081: Clarify timestamp filters impala-profile-tool accepts --min_timestamp and --max_timestamp filters for profile log entries, but the help text did not explain that these values are Unix epoch milliseconds. The parse error for invalid timestamp tokens also did not say which format was expected. Update the help and flag descriptions to document the expected unit, and include that unit in timestamp parse errors when filters are requested. Add a regression test for the error message. Assisted-by: OpenAI Codex Change-Id: I58cdd628f90253685d2a5f357a99f3f129db55b9 Reviewed-on: http://gerrit.cloudera.org:8080/24417 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/util/impala-profile-tool.cc M tests/observability/test_profile_tool.py 2 files changed, 40 insertions(+), 9 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24417 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I58cdd628f90253685d2a5f357a99f3f129db55b9 Gerrit-Change-Number: 24417 Gerrit-PatchSet: 7 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
