Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24547 )

Change subject: IMPALA-15154: Copy Hive ESRI geospatial UDFs into Impala
......................................................................


Patch Set 5:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24547/5/bin/jenkins/critique-gerrit-review.py
File bin/jenkins/critique-gerrit-review.py:

http://gerrit.cloudera.org:8080/#/c/24547/5/bin/jenkins/critique-gerrit-review.py@76
PS5, Line 76: v
flake8: E501 line too long (93 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/24547/5/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java
File 
fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java:

http://gerrit.cloudera.org:8080/#/c/24547/5/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@31
PS5, Line 31: import org.apache.impala.hive.geospatial.esri.*;
star import is not allowed. If you do need it, add it to 
JAVA_STAR_IMPORT_ALLOW_LIST in bin/jenkins/critique-gerrit-review.py.



--
To view, visit http://gerrit.cloudera.org:8080/24547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d078e6ee961c76b10915da6be5b86966ad9cefb
Gerrit-Change-Number: 24547
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 08 Jul 2026 18:16:33 +0000
Gerrit-HasComments: Yes

Reply via email to