Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24472 )
Change subject: IMPALA-12232: Validate JWT aud/iss claims ...................................................................... Patch Set 5: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24472/5/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/24472/5/be/src/rpc/authentication.cc@985 PS5, Line 985: LOG(ERROR) << "Error extracting username from OAuth token received from: " << client_ip line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24472/5/be/src/util/jwt-util-test.cc File be/src/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/24472/5/be/src/util/jwt-util-test.cc@1351 PS5, Line 1351: status = JWTHelper::VerifyJwtClaims(decoded_token.get(), {"missing-service"}, {"auth0"}); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24472/5/be/src/util/jwt-util-test.cc@1356 PS5, Line 1356: status = JWTHelper::VerifyJwtClaims(decoded_token.get(), {"impala-service"}, {"issuer2"}); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24472/5/be/src/util/jwt-util.cc File be/src/util/jwt-util.cc: http://gerrit.cloudera.org:8080/#/c/24472/5/be/src/util/jwt-util.cc@1087 PS5, Line 1087: return decoded_token->decoded_jwt_.get_payload_claim(claim_name).to_json().serialize(); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24472/5/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java: http://gerrit.cloudera.org:8080/#/c/24472/5/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@320 PS5, Line 320: execAndFetch(client, openResp.getSessionHandle(), "select logged_in_user()", "impala"); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24472 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a00b126359f2bc7e2f73d894cebc2b9014c7375 Gerrit-Change-Number: 24472 Gerrit-PatchSet: 5 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Wed, 08 Jul 2026 21:26:59 +0000 Gerrit-HasComments: Yes
