Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24549 )
Change subject: POC: Add WKB_EXPERIMENTAL geospatial serialization mode ...................................................................... Patch Set 3: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24549/3/be/src/util/backend-gflag-util.cc File be/src/util/backend-gflag-util.cc: http://gerrit.cloudera.org:8080/#/c/24549/3/be/src/util/backend-gflag-util.cc@535 PS3, Line 535: } else if (FLAGS_geospatial_library == to_string(TGeospatialLibrary::WKB_EXPERIMENTAL)) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24549/3/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/24549/3/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@31 PS3, Line 31: import org.apache.impala.hive.geospatial.esri.*; star import is not allowed. If you do need it, add it to JAVA_STAR_IMPORT_ALLOW_LIST in bin/jenkins/critique-gerrit-review.py. -- To view, visit http://gerrit.cloudera.org:8080/24549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb1b91171bf9a8834a55443d4a19518b38b759e Gerrit-Change-Number: 24549 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 08 Jul 2026 22:18:07 +0000 Gerrit-HasComments: Yes
