Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24547 )
Change subject: IMPALA-15154: Copy Hive ESRI geospatial UDFs into Impala ...................................................................... Patch Set 8: Code-Review+1 (5 comments) http://gerrit.cloudera.org:8080/#/c/24547/8/java/hive-geospatial-functions/pom.xml File java/hive-geospatial-functions/pom.xml: http://gerrit.cloudera.org:8080/#/c/24547/8/java/hive-geospatial-functions/pom.xml@29 PS8, Line 29: <groupId>org.apache.impala</groupId> It's inherited from the parent, not needed http://gerrit.cloudera.org:8080/#/c/24547/8/java/hive-geospatial-functions/pom.xml@36 PS8, Line 36: <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> Is this required? http://gerrit.cloudera.org:8080/#/c/24547/8/java/hive-geospatial-functions/pom.xml@43 PS8, Line 43: <version>2.2.4</version> Please externalize the version to the parent pom http://gerrit.cloudera.org:8080/#/c/24547/8/java/shaded-deps/hive-exec/pom.xml File java/shaded-deps/hive-exec/pom.xml: http://gerrit.cloudera.org:8080/#/c/24547/8/java/shaded-deps/hive-exec/pom.xml@137 PS8, Line 137: <include>org/apache/hadoop/hive/ql/exec/Description.class</include> Is this really required? We could remove the Description annotations from the classes and we could get rid of the dependency of this class http://gerrit.cloudera.org:8080/#/c/24547/8/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-extra.test File testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-extra.test: http://gerrit.cloudera.org:8080/#/c/24547/8/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-extra.test@157 PS8, Line 157: TODO: nit: it could be a ticket for future work -- To view, visit http://gerrit.cloudera.org:8080/24547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d078e6ee961c76b10915da6be5b86966ad9cefb Gerrit-Change-Number: 24547 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 11:56:27 +0000 Gerrit-HasComments: Yes
