Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24563 )
Change subject: IMPALA-15152: Update parquet.thrift to 2.13.0 ...................................................................... Patch Set 2: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24563/2/common/thrift/parquet.thrift File common/thrift/parquet.thrift: http://gerrit.cloudera.org:8080/#/c/24563/2/common/thrift/parquet.thrift@351 PS2, Line 351: struct Float16Type {} // allowed for FIXED[2], must be encoded as raw FLOAT16 bytes (see LogicalTypes.md) line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/24563/2/common/thrift/parquet.thrift@506 PS2, Line 506: 5: DecimalType DECIMAL // use ConvertedType DECIMAL + SchemaElement.{scale, precision} line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24563/2/common/thrift/parquet.thrift@782 PS2, Line 782: definition_levels_byte_length + repetition_levels_byte_length and compressed_page_size (included) line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/24563/2/common/thrift/parquet.thrift@1012 PS2, Line 1012: * reference implementations that will read externally stored column data if this field is populated line too long (103 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b6e7d2fe1939821a000251ef76afc44d92e0332 Gerrit-Change-Number: 24563 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 13:11:02 +0000 Gerrit-HasComments: Yes
