Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24540 )
Change subject: POC: Port native C++ geospatial functions to WKB mode ...................................................................... Patch Set 6: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24540/6/be/src/exprs/geo/bin-utils.h File be/src/exprs/geo/bin-utils.h: http://gerrit.cloudera.org:8080/#/c/24540/6/be/src/exprs/geo/bin-utils.h@27 PS6, Line 27: // https://github.com/Esri/spatial-framework-for-hadoop/blob/7226df669cbfaaf1edbfac0461acd1af45e12b81/hive/src/main/java/com/esri/hadoop/hive/BinUtils.java line too long (155 > 90) http://gerrit.cloudera.org:8080/#/c/24540/6/be/src/exprs/geo/geospatial-functions-wkb-ir.cc File be/src/exprs/geo/geospatial-functions-wkb-ir.cc: http://gerrit.cloudera.org:8080/#/c/24540/6/be/src/exprs/geo/geospatial-functions-wkb-ir.cc@511 PS6, Line 511: // TODO: could parse the point count directly from WKB bytes, avoiding full deserialization. line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24540/6/be/src/exprs/geo/geospatial-functions-wkb-ir.cc@519 PS6, Line 519: // TODO: could read the sub-geometry count directly from WKB bytes (offset 5-8 for multi types). line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/24540/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/24540/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@31 PS6, Line 31: import org.apache.impala.hive.geospatial.esri.*; star import is not allowed. If you do need it, add it to JAVA_STAR_IMPORT_ALLOW_LIST in bin/jenkins/critique-gerrit-review.py. http://gerrit.cloudera.org:8080/#/c/24540/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@435 PS6, Line 435: addNativeWithGeomState(db, "st_LineString", "_WKB", false, Type.GEOMETRY, Type.STRING); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24540/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@437 PS6, Line 437: addNativeWithGeomState(db, "st_MultiPoint", "_WKB", false, Type.GEOMETRY, Type.STRING); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0047acebd4aaa774bf6bb8ec0618515d38ad6aae Gerrit-Change-Number: 24540 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 14:32:41 +0000 Gerrit-HasComments: Yes
