Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24271 )
Change subject: IMPALA-14904: Calcite planner: Enable width_bucket function ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/24271/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/24271/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@492 PS12, Line 492: Preconditions.checkState(fn.getArgs()[i].isDecimal()); > Is this unsafe if i==fn.getArgs().length? Could you use checkState(t.isDeci Yeah, and then there is really no point in checking if t is a decimal because it is already a wildcard decimal, so I removed this statement. http://gerrit.cloudera.org:8080/#/c/24271/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java: http://gerrit.cloudera.org:8080/#/c/24271/12/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@476 PS12, Line 476: if ((r1.getPrecision() == -1 && r1.getScale() == 0) || > Why do we check wildcard this way instead of isWildcardDecimal? These are Calcite RelDataTypes, not Impala ScalarTypes. -- To view, visit http://gerrit.cloudera.org:8080/24271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2944fde1301e48b3fb0c29be7290b1ad9533e5b6 Gerrit-Change-Number: 24271 Gerrit-PatchSet: 12 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 19:04:45 +0000 Gerrit-HasComments: Yes
