Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24558 )
Change subject: IMPALA-15019: Avoid materializing non-projected filtered partition column in Calcite planner. ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/24558/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24558/6//COMMIT_MSG@7 PS6, Line 7: IMPALA-15019: Avoid materializing non-projected filtered partition column in Calcite planner. nit: extra space in the title message, and it's a bit long. http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@129 PS6, Line 129: // Optimization for parititoned scan node columns that are not used in typo: partitioned http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@250 PS6, Line 250: List<RexNode> projects) { projects argument is unused, looks like you instead call getProjects() against in the lambda capture. http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/24558/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@263 PS6, Line 263: * FILTER_PROJECT_TRANSPOSE: One last transpose is done since the physical Comment still mentions FILTER_PROJECT_TRANSPOSE. http://gerrit.cloudera.org:8080/#/c/24558/6/testdata/workloads/functional-query/queries/QueryTest/hbo-multiple-scans.test File testdata/workloads/functional-query/queries/QueryTest/hbo-multiple-scans.test: http://gerrit.cloudera.org:8080/#/c/24558/6/testdata/workloads/functional-query/queries/QueryTest/hbo-multiple-scans.test@149 PS6, Line 149: # query is from a join and an added "id is not null" predicate Is this something HBO might want to address later? -- To view, visit http://gerrit.cloudera.org:8080/24558 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I902dc625963321aff57e5c05af3d1137c06aa882 Gerrit-Change-Number: 24558 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 22:34:22 +0000 Gerrit-HasComments: Yes
