Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10863 )
Change subject: IMPALA-7240: Fix missing QueryMaintenance call in AddBatchStreaming ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10863/1/be/src/exec/grouping-aggregator.cc File be/src/exec/grouping-aggregator.cc: http://gerrit.cloudera.org:8080/#/c/10863/1/be/src/exec/grouping-aggregator.cc@407 PS1, Line 407: SCOPED_TIMER(build_timer_); > Do we have a similar bug here? I'm not sure how expr_results_pool_ gets cle Yep. Submitted this so to get the builds green, and filed a new review: https://gerrit.cloudera.org/#/c/10871/ Since the ExecNode::expr_results_pool_ isn't being used anyways, my suggestion is to keep Aggregator::expr_results_pool_ and then eliminate the calls to QueryMaintenance() in the exec nodes to get rid of the duplication. I don't feel strongly about it, though, happy to implement one of your proposed solutions instead. -- To view, visit http://gerrit.cloudera.org:8080/10863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I150a46d00acad139d186a150d9706ef47a10ac36 Gerrit-Change-Number: 10863 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 05 Jul 2018 21:22:44 +0000 Gerrit-HasComments: Yes
