Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24571 )
Change subject: IMPALA-13953: Deprecate use_local_tz_for_unix_timestamp_conversions flag ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/24571/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24571/1//COMMIT_MSG@11 PS1, Line 11: changes typo http://gerrit.cloudera.org:8080/#/c/24571/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/24571/1/be/src/service/impala-server.cc@a415 PS1, Line 415: Can you mark this as deprecated now? Ideally we should remove both at the same time, but for some reason this was not marked as deprecated, so we need to wait for next major release. http://gerrit.cloudera.org:8080/#/c/24571/1/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/24571/1/tests/custom_cluster/test_kudu.py@77 PS1, Line 77: test_local_tz_conversion_ops This has no custom flags anymore, so can be moved to query_test/test_kudu.py http://gerrit.cloudera.org:8080/#/c/24571/1/tests/custom_cluster/test_local_tz_conversion.py File tests/custom_cluster/test_local_tz_conversion.py: http://gerrit.cloudera.org:8080/#/c/24571/1/tests/custom_cluster/test_local_tz_conversion.py@a50 PS1, Line 50: It seems that all tests are executed from test_exprs.py too - can you mention this in the commit message? -- To view, visit http://gerrit.cloudera.org:8080/24571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1245783ba45a42f02f649ac122c1ce74938f5141 Gerrit-Change-Number: 24571 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 13 Jul 2026 10:01:15 +0000 Gerrit-HasComments: Yes
