Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24190 )
Change subject: IMPALA-14882: part1: Convert arrow record batch to impala tuple batch ...................................................................... Patch Set 24: (4 comments) Thanks for the review! I found a couple more issues, will resolve all together. http://gerrit.cloudera.org:8080/#/c/24190/24/be/src/exec/arrow-converter-test.cc File be/src/exec/arrow-converter-test.cc: http://gerrit.cloudera.org:8080/#/c/24190/24/be/src/exec/arrow-converter-test.cc@110 PS24, Line 110: EXPECT_EQ(value->Len(), original_value.size()); nit: comparing int to size_t, probably worth an explicit cast http://gerrit.cloudera.org:8080/#/c/24190/24/be/src/exec/arrow-converter.cc File be/src/exec/arrow-converter.cc: http://gerrit.cloudera.org:8080/#/c/24190/24/be/src/exec/arrow-converter.cc@311 PS24, Line 311: writer.reset(new VarCharSlotWriter(slot_desc, array, type.len)); Missing break; after this! http://gerrit.cloudera.org:8080/#/c/24190/24/be/src/exec/arrow-converter.cc@407 PS24, Line 407: Unaligned Unaligned allocation will cause issues with larger types. http://gerrit.cloudera.org:8080/#/c/24190/24/be/src/exec/arrow-converter.cc@417 PS24, Line 417: DCHECK(writer.get() != nullptr); This will crash in case of complex types. Better to return a status with an error message (e.g. complex types are not supported) -- To view, visit http://gerrit.cloudera.org:8080/24190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea544b3c71d9211c893f0fec3527ebe84155ebcd Gerrit-Change-Number: 24190 Gerrit-PatchSet: 24 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: jichen <[email protected]> Gerrit-Comment-Date: Mon, 13 Jul 2026 10:36:59 +0000 Gerrit-HasComments: Yes
