Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24337 )

Change subject: IMPALA-14954: Support ADMIN OPTION clause for GRANT/REVOKE ROLE
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24337/11/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:

http://gerrit.cloudera.org:8080/#/c/24337/11/tests/authorization/test_ranger.py@2431
PS11, Line 2431: with self.create_impala_client(user=ADMIN) as admin_client, \
               :         self.create_impala_client(user=user_1) as 
user_1_client:
Looks like our build environment does not that the parentheses of this with 
statement at https://jenkins.impala.io/job/python-check-ub2004/13306/console.

 11:22:44 Python 3 compilation failed for tests/authorization/test_ranger.py:
 11:22:44 *** Error compiling 'tests/authorization/test_ranger.py'...
 11:22:44   File "tests/authorization/test_ranger.py", line 2431
 11:22:44     with (self.create_impala_client(user=ADMIN) as admin_client,

I fixed this in patch set 12.



--
To view, visit http://gerrit.cloudera.org:8080/24337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e7c9ba091bc15271c7a3ef34ca06a38630d5bb6
Gerrit-Change-Number: 24337
Gerrit-PatchSet: 12
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Mon, 13 Jul 2026 18:56:21 +0000
Gerrit-HasComments: Yes

Reply via email to