Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24567 )
Change subject: IMPALA-15158: Replace ColumnType.is_binary_ with an enum ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/24567/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24567/5//COMMIT_MSG@9 PS5, Line 9: e nit: a http://gerrit.cloudera.org:8080/#/c/24567/5/be/src/exec/hbase/hbase-table-writer.cc File be/src/exec/hbase/hbase-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/24567/5/be/src/exec/hbase/hbase-table-writer.cc@169 PS5, Line 169: DCHECK(false) << "Unexpected string subtype"; might help to add "<< col_desc.type().StringSubtype()" to know what the unexpected value is when encountered. -- To view, visit http://gerrit.cloudera.org:8080/24567 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I667138dac8afdd117dea8ed90a85927352f73269 Gerrit-Change-Number: 24567 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 15 Jul 2026 07:30:10 +0000 Gerrit-HasComments: Yes
