Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10873 )
Change subject: IMPALA-6031: Distributed plan describes coordinator-only nodes as scanning ...................................................................... Patch Set 2: (7 comments) Change looks good to me - we discussed the approach earlier. Just have some cleanup suggestions to make it easier for future people to read. http://gerrit.cloudera.org:8080/#/c/10873/2/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/10873/2/common/thrift/Frontend.thrift@715 PS2, Line 715: // from the Membership heartbeat. Briefly mention that it only includes executors? http://gerrit.cloudera.org:8080/#/c/10873/2/common/thrift/Frontend.thrift@719 PS2, Line 719: num_executor_nodes num_executors. http://gerrit.cloudera.org:8080/#/c/10873/2/fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java File fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java: http://gerrit.cloudera.org:8080/#/c/10873/2/fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java@28 PS2, Line 28: * Singleton class that represents a snapshot of the Impalad cluster membership. Host Briefly mention that it only contains executors. http://gerrit.cloudera.org:8080/#/c/10873/2/fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java@34 PS2, Line 34: MembershipSnapshot ExecutorMembershipSnapshot http://gerrit.cloudera.org:8080/#/c/10873/2/fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java@49 PS2, Line 49: MembershipSnapshot ExecutorMembershipSnapshot http://gerrit.cloudera.org:8080/#/c/10873/2/fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java@54 PS2, Line 54: numExecutorNodes_ Maybe numExecutors_? http://gerrit.cloudera.org:8080/#/c/10873/2/tests/custom_cluster/test_coordinators.py File tests/custom_cluster/test_coordinators.py: http://gerrit.cloudera.org:8080/#/c/10873/2/tests/custom_cluster/test_coordinators.py@274 PS2, Line 274: "where id NOT IN (0,1,2) and string_col IN ('aaaa', 'bbbb', 'cccc', NULL) "\ nit: continuations might not be needed because this is in parentheses -- To view, visit http://gerrit.cloudera.org:8080/10873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44af6b40099a495e13a0a5dc72c491d486d23aa8 Gerrit-Change-Number: 10873 Gerrit-PatchSet: 2 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 00:19:36 +0000 Gerrit-HasComments: Yes
