Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24572 )

Change subject: IMPALA-15171: Null out Iceberg delete file path slot after the 
join
......................................................................


Patch Set 2:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24572/2/be/src/exec/hdfs-scan-node-base.h
File be/src/exec/hdfs-scan-node-base.h:

http://gerrit.cloudera.org:8080/#/c/24572/2/be/src/exec/hdfs-scan-node-base.h@703
PS2, Line 703:   /// True if the INPUT__FILE__NAME virtual slot on this scan's 
tuple was materialized only
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/24572/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java
File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java:

http://gerrit.cloudera.org:8080/#/c/24572/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@164
PS2, Line 164:   // join key for the position-delete ANTI JOIN, i.e. nothing 
above the scan references it.
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/24572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e662cb6a98dd3e687185d384731d6be45f91b94
Gerrit-Change-Number: 24572
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Thu, 16 Jul 2026 17:15:23 +0000
Gerrit-HasComments: Yes

Reply via email to