Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24549 )
Change subject: IMPALA-15160: Add WKB_EXPERIMENTAL geospatial serialization mode ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/24549/3/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/24549/3/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@86 PS3, Line 86: new ArrayList<> > What is the reason for this change? bump http://gerrit.cloudera.org:8080/#/c/24549/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/24549/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@125 PS6, Line 125: boolean isWkb This arg pushdown could be eliminated by reading GeometryUtils.getFormat at createRelationalGenericUDFs http://gerrit.cloudera.org:8080/#/c/24549/6/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/24549/6/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@118 PS6, Line 118: if (geoLib.equals(TGeospatialLibrary.HIVE_ESRI) : || geoLib.equals(TGeospatialLibrary.WKB_EXPERIMENTAL) nit:Not NONE http://gerrit.cloudera.org:8080/#/c/24549/6/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/GeometryUtils.java File java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/GeometryUtils.java: http://gerrit.cloudera.org:8080/#/c/24549/6/java/hive-geospatial-functions/src/main/java/org/apache/impala/hive/geospatial/esri/GeometryUtils.java@40 PS6, Line 40: private static volatile SerializationFormat format = SerializationFormat.ESRI_SHAPE; nit: This is quite ugly, but I recognize the pain brought in by a static util class. A proper solution would make this a singleton with a capability of providing a serializer, but I see that this change tries to keep the imported code clean from big refactors. I hope it doesn't stay in the repo for long. -- To view, visit http://gerrit.cloudera.org:8080/24549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifbb1b91171bf9a8834a55443d4a19518b38b759e Gerrit-Change-Number: 24549 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 17 Jul 2026 14:34:02 +0000 Gerrit-HasComments: Yes
