Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24485 )
Change subject: IMPALA-15088: Add ReadOnlyIntGauge ...................................................................... IMPALA-15088: Add ReadOnlyIntGauge Add ReadOnlyIntGauge as the common read-only interface for integer gauge metrics. SumGauge, NegatedGauge, MemTracker consumption metrics, and malloc memory metric accessors now use the read-only interface. This lets both IntGauge and FunctionGauge satisfy code that only needs GetValue(). Replace the derived tcmalloc total-bytes-reserved and overhead metric classes with FunctionGauge instances. Testing: - git diff --check asf-gerrit/master..HEAD - python3 bin/jenkins/critique-gerrit-review.py --dryrun - focused Linux build: MallocUtilGoogleTcmalloc - focused Linux build: unified-be-test-executable - focused Linux test: MetricsTest.* (46 tests) Assisted-by: OpenAI Codex Change-Id: Ida124aa3225ee07cf30e9f0a481477474a50c4dd Reviewed-on: http://gerrit.cloudera.org:8080/24485 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/runtime/exec-env.cc M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h M be/src/scheduling/admission-controller.cc M be/src/util/malloc-util-googletcmalloc.h M be/src/util/malloc-util-gperftools.h M be/src/util/malloc-util-libc.h M be/src/util/malloc-util-sanitizers.h M be/src/util/malloc-util.h M be/src/util/memory-metrics.cc M be/src/util/metrics-fwd.h M be/src/util/metrics-test.cc M be/src/util/metrics.h 13 files changed, 85 insertions(+), 83 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24485 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ida124aa3225ee07cf30e9f0a481477474a50c4dd Gerrit-Change-Number: 24485 Gerrit-PatchSet: 4 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
