Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24600 )

Change subject: IMPALA-15121: Fix query failure when catalogd is in standby 
mode during HA failover
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/24600/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java
File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java:

http://gerrit.cloudera.org:8080/#/c/24600/1/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@498
PS1, Line 498:       String errorMsg = String.join("\n", 
resp.status.error_msgs);
> Could we handle this with a specific status_code instead of parsing the err
Done. Added a new error code CATALOG_IN_STANDBY_MODE.


http://gerrit.cloudera.org:8080/#/c/24600/1/tests/custom_cluster/test_catalogd_ha.py
File tests/custom_cluster/test_catalogd_ha.py:

http://gerrit.cloudera.org:8080/#/c/24600/1/tests/custom_cluster/test_catalogd_ha.py@835
PS1, Line 835:
> flake8: U100 Unused argument 'unique_database'
Done


http://gerrit.cloudera.org:8080/#/c/24600/1/tests/custom_cluster/test_catalogd_ha.py@853
PS1, Line 853:     
standby_catalogd.service.wait_for_metric_value('catalog-server.active-status',
> Is there a metric we could wait on instead?
Done



--
To view, visit http://gerrit.cloudera.org:8080/24600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia511e22a596733e6a2dd752894d6da43e91faca6
Gerrit-Change-Number: 24600
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Sat, 18 Jul 2026 02:25:59 +0000
Gerrit-HasComments: Yes

Reply via email to