Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24604 )
Change subject: tested performance stuff ...................................................................... Patch Set 1: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java: http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@27 PS1, Line 27: import org.apache.calcite.rel.core.Aggregate; unused import: org.apache.calcite.rel.core.Aggregate http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@29 PS1, Line 29: import org.apache.calcite.rel.core.Project; unused import: org.apache.calcite.rel.core.Project http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@32 PS1, Line 32: import org.apache.calcite.rel.metadata.RelColumnOrigin;; unused import: org.apache.calcite.rel.metadata.RelColumnOrigin; http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaCost.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaCost.java: http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaCost.java@144 PS1, Line 144: || Math.abs(1.0 - (this.cpu + this.io) / (other.getCpu() + other.getIo())) < EPSILON; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java: http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@56 PS1, Line 56: import java.util.List; unused import: java.util.List http://gerrit.cloudera.org:8080/#/c/24604/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java@133 PS1, Line 133: runOptimizeNodesProgram(relBuilder, rexBuilder, optimizedJoinPlan, simplifier, true); line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a0a6cbd006fadfc39f0e7374711c65ca1d5de2a Gerrit-Change-Number: 24604 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 18 Jul 2026 22:21:39 +0000 Gerrit-HasComments: Yes
