Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24364 )
Change subject: IMPALA-14982: Add Impala-on-K8s deployment guide ...................................................................... Patch Set 37: (2 comments) http://gerrit.cloudera.org:8080/#/c/24364/37/helm/impala/README.md File helm/impala/README.md: http://gerrit.cloudera.org:8080/#/c/24364/37/helm/impala/README.md@254 PS37, Line 254: "ldapEnabled": true, This LDAP enablement patch likely needs ldapValuesFile (OpenLDAP chart values) to be reliable. As written, operator defaults can point to Impala LDAP values while installing openldap/openldap, which may fail or apply unintended defaults. Could we either add ldapValuesFile explicitly to this example or call out the required operator env override? http://gerrit.cloudera.org:8080/#/c/24364/37/helm/impala/README.md@256 PS37, Line 256: "ldapBindPattern": "cn=#UID\\\\,dc=example\\\\,dc=org" In the operator flow, this ldapBindPattern looks pre-escaped. Since the operator already escapes values when building Helm --set-string args, this can double-escape commas and pass a broken bind pattern to Impala. Can we document the CR value as raw DN syntax instead (e.g. cn=#UID,dc=example,dc=org) and keep comma-escaping guidance only for direct Helm CLI --set usage? -- To view, visit http://gerrit.cloudera.org:8080/24364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a7d1a2f0254209143f05bd417c64410cc282985 Gerrit-Change-Number: 24364 Gerrit-PatchSet: 37 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Mon, 20 Jul 2026 21:29:59 +0000 Gerrit-HasComments: Yes
