Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24598 )
Change subject: IMPALA-9153: Generate CUP parser Java source via CMake ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24598/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24598/2//COMMIT_MSG@17 PS2, Line 17: maintaining our own custom Maven plugin for our version > I think we already own the CUP parser generator as the used version is '0.1 The basic situation is that we do need our specific version of CUP and there aren't new versions of either CUP or the Maven CUP plugin that do exactly what we need without customization. I have tried maintaining a custom CUP Maven plugin, and it is possible. I found it to be a fair amount of code and complication, so I prefer the CMake approach. http://gerrit.cloudera.org:8080/#/c/24598/2/bin/cmake_aux/generate-cup-sources.sh File bin/cmake_aux/generate-cup-sources.sh: http://gerrit.cloudera.org:8080/#/c/24598/2/bin/cmake_aux/generate-cup-sources.sh@28 PS2, Line 28: JAVA_CUP_JAR=java-cup-0.11-a-czt02-cdh.jar > nit: impala-config.sh might set this version We do use it in multiple places, I'll take a look -- To view, visit http://gerrit.cloudera.org:8080/24598 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I180b191b72b54e3661726e1560be844341ed92e5 Gerrit-Change-Number: 24598 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2026 05:06:53 +0000 Gerrit-HasComments: Yes
