Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24614 )
Change subject: IMPALA-12587: Respect MAX_FS_WRITERS for Iceberg DELETE/UPDATE/MERGE ...................................................................... Patch Set 2: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24614/2/fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java File fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java: http://gerrit.cloudera.org:8080/#/c/24614/2/fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java@40 PS2, Line 40: public class JoinBuildSink extends DataSink implements SpillableOperator, InstanceCountProvidingSink { line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/24614/2/fe/src/test/java/org/apache/impala/planner/IcebergWriterLimitTest.java File fe/src/test/java/org/apache/impala/planner/IcebergWriterLimitTest.java: http://gerrit.cloudera.org:8080/#/c/24614/2/fe/src/test/java/org/apache/impala/planner/IcebergWriterLimitTest.java@30 PS2, Line 30: import org.apache.impala.thrift.TExecRequest; unused import: org.apache.impala.thrift.TExecRequest -- To view, visit http://gerrit.cloudera.org:8080/24614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice7362cecb8b43fbff43b8ad82827e31e2b4eea3 Gerrit-Change-Number: 24614 Gerrit-PatchSet: 2 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 21 Jul 2026 15:52:50 +0000 Gerrit-HasComments: Yes
