Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24595 )
Change subject: IMPALA-15149: Add type-aware Trino result verification ...................................................................... Patch Set 3: > Patch Set 2: > > The new Trino tests failed with: > > conftest.py:254: in pytest_generate_tests > assert issubclass(metafunc.cls, > tests.common.base_test_suite.BaseTestSuite) > E TypeError: issubclass() arg 1 must be a class > metafunc = <_pytest.python.Metafunc object at 0x7fd2d52cb490> Thanks for catching this. PS3 moves the two new unit-test modules into BaseTestSuite-derived classes, as required by tests/conftest.py. I re-ran collection with the repository-level conftest enabled: all 35 tests were collected, and the focused run passed all 35. Gerrit critic is clean. -- To view, visit http://gerrit.cloudera.org:8080/24595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9effef8938a02567a4a9adc7d4fa78917a2f6d8c Gerrit-Change-Number: 24595 Gerrit-PatchSet: 3 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 22 Jul 2026 17:00:44 +0000 Gerrit-HasComments: No
