Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10871 )
Change subject: IMPALA-7251: Fix QueryMaintenance calls in Aggregators ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10871/1/testdata/workloads/functional-query/queries/QueryTest/spilling-regression-exhaustive.test File testdata/workloads/functional-query/queries/QueryTest/spilling-regression-exhaustive.test: http://gerrit.cloudera.org:8080/#/c/10871/1/testdata/workloads/functional-query/queries/QueryTest/spilling-regression-exhaustive.test@253 PS1, Line 253: select count(distinct concat(cast(l_comment as char(120)), cast(l_comment as char(120)), > I think there's still a similar bug in NonGroupingAggregator if the express I fixed the NonGroupingAggregator part. For the mem_tracker stuff, turns out its not quite trivial to fix - if you just initialize Aggregator::mem_tracker_ with ExecNode::mem_tracker as its parent you end up with issues with mismatched parent links when calling ReservationTracker::InitChildTracker() during ClaimBufferReservation(). I filed IMPALA-7256 -- To view, visit http://gerrit.cloudera.org:8080/10871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4dac2bb0a15cdd7315ee15608bae409c125c82f5 Gerrit-Change-Number: 10871 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 21:02:07 +0000 Gerrit-HasComments: Yes
