Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24634 )

Change subject: IMPALA-12889: Changing file format to AVRO doesn't update 
schema using 'avro.schema.url'
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/24634/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/24634/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1374
PS1, Line 1374: IMPALA-12889:
nit: We usually don't add JIRA ids like this if the comment already explains 
the code well.


http://gerrit.cloudera.org:8080/#/c/24634/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1378
PS1, Line 1378:           reloadTableSchema = true;
Let's only set this when the old/new file format is AVRO. For other formats, 
it's a waste to reload the schema.



--
To view, visit http://gerrit.cloudera.org:8080/24634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0aaf707fb2879b26518f8b6d532087f92d85dfcb
Gerrit-Change-Number: 24634
Gerrit-PatchSet: 1
Gerrit-Owner: Tarun Jangid <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Wed, 29 Jul 2026 07:54:12 +0000
Gerrit-HasComments: Yes

Reply via email to