Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py File tests/metadata/test_ddl_base.py: http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py@96 PS7, Line 96: _get_property > Yes, it's generic enough to get a single property value. The format is cons ok, lets clarify in the comment that a single row is expected. better to assert it in case things change later on and we wind up depending on the order of items in these sections. -- To view, visit http://gerrit.cloudera.org:8080/10822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1 Gerrit-Change-Number: 10822 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 06 Jul 2018 21:18:35 +0000 Gerrit-HasComments: Yes
