Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/24579 )
Change subject: IMPALA-15139: Support DELTA_LENGTH_BYTE_ARRAY Parquet encoding ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/24579/9/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/24579/9/be/src/exec/parquet/parquet-column-readers.cc@1063 PS9, Line 1063: col_chunk_reader_.keep_data_page_pool_ = true; : } : return true; : } : : // StringValue PLAIN: Check if all strings could be smallified. : // If not, data page pool has to be kept, because string ptr points into it. : template <> : tem > It seem better (potentially faster?) to do this within NextValues, e.g. by Yeah, it's much better. http://gerrit.cloudera.org:8080/#/c/24579/9/testdata/parquet_delta_length_byte_array_encoding/parquet_files_generator.py File testdata/parquet_delta_length_byte_array_encoding/parquet_files_generator.py: http://gerrit.cloudera.org:8080/#/c/24579/9/testdata/parquet_delta_length_byte_array_encoding/parquet_files_generator.py@37 PS9, Line 37: on-n > Are you sure that this is enough for to use RLE encoding? Not sure how Trin Yeah, the batch path still wasn't triggered. Added more rows and now it surely calls to DecodeValues(). -- To view, visit http://gerrit.cloudera.org:8080/24579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e4395fa30cd7fb2c89ef5a2b16b043d4de60b52 Gerrit-Change-Number: 24579 Gerrit-PatchSet: 10 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 29 Jul 2026 12:22:05 +0000 Gerrit-HasComments: Yes
