Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24635 )
Change subject: IMPALA-15221: Harden VARIANT decoding against corrupt input ...................................................................... Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/24635/5/be/src/runtime/variant-value.h File be/src/runtime/variant-value.h: http://gerrit.cloudera.org:8080/#/c/24635/5/be/src/runtime/variant-value.h@172 PS5, Line 172: bool GetBoolean(bool* out) const; : bool GetInt8(int8_t* out) const; : bool GetInt16(int16_t* out) const; : bool GetInt32(int32_t* out) const; : bool GetInt64(int64_t* out) const; : bool GetFloat(float* out) const; : bool GetDouble(double* out) const; : bool GetString(StringValue* out) const; : bool GetBinary(StringValue* out) const; These methods should be [[nodiscard]] http://gerrit.cloudera.org:8080/#/c/24635/5/be/src/runtime/variant-value.cc File be/src/runtime/variant-value.cc: http://gerrit.cloudera.org:8080/#/c/24635/5/be/src/runtime/variant-value.cc@474 PS5, Line 474: Malformed variant short string A small helper that constructs the error message could help with the error strings http://gerrit.cloudera.org:8080/#/c/24635/5/be/src/util/variant-util-test.cc File be/src/util/variant-util-test.cc: http://gerrit.cloudera.org:8080/#/c/24635/5/be/src/util/variant-util-test.cc@851 PS5, Line 851: (IMPALA-15221) nit: not needed -- To view, visit http://gerrit.cloudera.org:8080/24635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a22bb16cd05854a9afb56ebd27806ac52670bca Gerrit-Change-Number: 24635 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 29 Jul 2026 12:53:01 +0000 Gerrit-HasComments: Yes
