Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10822 )
Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py File tests/metadata/test_ddl_base.py: http://gerrit.cloudera.org:8080/#/c/10822/7/tests/metadata/test_ddl_base.py@96 PS7, Line 96: _get_property > ok, lets clarify in the comment that a single row is expected. better to as there's a fair bit of repetition here from _get_properties. perhaps it would be easiest to just call it, assert a single entry, and return the key? -- To view, visit http://gerrit.cloudera.org:8080/10822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b75b1590b16eb0c2ba326d07ee3fd9897c27d1 Gerrit-Change-Number: 10822 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 21:37:52 +0000 Gerrit-HasComments: Yes
