Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24642 )
Change subject: IMPALA-15229: Derive the EC Policy column from file metadata, not RPCs ...................................................................... Patch Set 1: (2 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/24642/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/24642/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@747 PS1, Line 747: return FileSystemUtil.getErasureCodingPolicy(p.getLocationPath()); Can sawNonEc=true at this point? If so, we should probably return MIXED. Please also add a test for this. http://gerrit.cloudera.org:8080/#/c/24642/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/24642/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@371 PS1, Line 371: Map<Byte, String> names = EC_POLICY_NAME_CACHE.get(fs.getUri().toString()); : if (names == null) { : names = new HashMap<>(); : for (ErasureCodingPolicyInfo info : : ((DistributedFileSystem) fs).getAllErasureCodingPolicies()) { : names.put(info.getPolicy().getId(), info.getPolicy().getName()); : } : EC_POLICY_NAME_CACHE.put(fs.getUri().toString(), names); You could use computeIfAbsent() so concurrent callers of this method won't invoke RPCs and write the map in parallel. -- To view, visit http://gerrit.cloudera.org:8080/24642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35fc413c4a1f4730baab55406b13f5541f379707 Gerrit-Change-Number: 24642 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 18:00:41 +0000 Gerrit-HasComments: Yes
