Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24643 )
Change subject: IMPALA-12675: Add simdutf 9.0.0 ...................................................................... Patch Set 1: (1 comment) Looks good I'd still like to ask for a shared lib variant as well; otherwise looks OK. http://gerrit.cloudera.org:8080/#/c/24643/1/source/simdutf/build.sh File source/simdutf/build.sh: http://gerrit.cloudera.org:8080/#/c/24643/1/source/simdutf/build.sh@41 PS1, Line 41: DBUILD_SHARED_LIBS=OFF We haven't yet given up on dynamically-linked Impala builds completely, so could you add building a shared lib for this? Several Google utilities (gflags, gtest) have examples. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/24643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idde4e91cdf2d556804bdaa7f2e01f07ad2e30558 Gerrit-Change-Number: 24643 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 18:11:53 +0000 Gerrit-HasComments: Yes
