Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24649 )
Change subject: IMPALA-5406: Move Kudu SHOW CREATE TABLE tests to .test file ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/24649/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24649/1//COMMIT_MSG@14 PS1, Line 14: Removed class TestShowCreateTable The class is still there. http://gerrit.cloudera.org:8080/#/c/24649/1/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/24649/1/tests/query_test/test_kudu.py@a1253 PS1, Line 1253: : : : : : : : These are missing from the .test file. http://gerrit.cloudera.org:8080/#/c/24649/1/tests/query_test/test_kudu.py@a1263 PS1, Line 1263: This does not have a replacement in the .test file, keep it. http://gerrit.cloudera.org:8080/#/c/24649/1/tests/query_test/test_kudu.py@1057 PS1, Line 1057: @SkipIfKudu.hms_integration_enabled() Please double-check if we still need this annotation. From the old tests at least 'test_synchronized_kudu_table_with_show_create()' did not have the annotation. So the current change narrows testing. -- To view, visit http://gerrit.cloudera.org:8080/24649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie29e770a5546018c7dcd94b7018bd3c619639da2 Gerrit-Change-Number: 24649 Gerrit-PatchSet: 1 Gerrit-Owner: Gowthami Bisati <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 11:40:20 +0000 Gerrit-HasComments: Yes
