Hello Bikramjeet Vig, Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10886
to look at the new patch set (#2).
Change subject: IMPALA-7216: Fix SQL generated by toSql functions in
CreateViewStmt & AlterViewStmt
......................................................................
IMPALA-7216: Fix SQL generated by toSql functions in CreateViewStmt &
AlterViewStmt
The toSql functions in CreateViewStmt and AlterViewStmt generated
invalid SQL by appending types to column definitions. This change
appends just the column names to fix it.
Testing: Added tests to ToSqlTest to verify it.
Change-Id: Ie2a834d4d8d11ba18262d2828f4829c80ed05190
---
M fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java
M fe/src/main/java/org/apache/impala/analysis/CreateOrAlterViewStmtBase.java
M fe/src/main/java/org/apache/impala/analysis/CreateViewStmt.java
M fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java
4 files changed, 81 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/10886/2
--
To view, visit http://gerrit.cloudera.org:8080/10886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2a834d4d8d11ba18262d2828f4829c80ed05190
Gerrit-Change-Number: 10886
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
