Anubhav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24368 )
Change subject: IMPALA-15028: Add Helm chart render assertions ...................................................................... Patch Set 51: (5 comments) Done http://gerrit.cloudera.org:8080/#/c/24368/50/bin/jenkins/all-tests.sh File bin/jenkins/all-tests.sh: http://gerrit.cloudera.org:8080/#/c/24368/50/bin/jenkins/all-tests.sh@35 PS50, Line 35: # platforms that don't install ninja. > Start with defaulting to "false" so these tests are only run on-demand. Done, chart test gate now defaults off (HELM_CHART_TEST=false) http://gerrit.cloudera.org:8080/#/c/24368/50/bin/jenkins/all-tests.sh@101 PS50, Line 101: exit $RET_CODE : : : : > The code changes in this file would make more sense in bin/run-all-tests.sh Moved integration from bin/jenkins/all-tests.sh to bin/run-all-tests.sh http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/README.md File helm/impala/README.md: http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/README.md@388 PS50, Line 388: ## Automated chart checks > Please add documentation about the required dependencies to run this test ( Added dependency docs in Helm README for running the chart harness. http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/assert_chart.py File helm/impala/tests/assert_chart.py: http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/assert_chart.py@1 PS50, Line 1: #!/usr/bin/env impala-python3 > This file must be marked executable (permissions 755). Updated assert_chart.py shebang to #!/usr/bin/env impala-python3 and kept it executable. http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/run-chart-tests.sh File helm/impala/tests/run-chart-tests.sh: http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/run-chart-tests.sh@153 PS50, Line 153: echo "Expected helm template to fail without external Ranger admin URL." > This script should not be executed using the "python3" command. Instead, a Updated run-chart-tests.sh to invoke assert_chart.py directly. -- To view, visit http://gerrit.cloudera.org:8080/24368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I313be431e81a4b98370e51d298b7b2d35e0aded8 Gerrit-Change-Number: 24368 Gerrit-PatchSet: 51 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 22:16:34 +0000 Gerrit-HasComments: Yes
